Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 36accaed authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

isdn: return -EFAULT if copy_from_user() fails 



We should be returning -EFAULT here.

Mostly this patch is to silence a smatch warning.  The upper levels
of this driver turn all non-zero return values from isar_load_firmware()
into 1.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5d52040d

drivers/isdn/hisax/isar.c

+2 −2
Original line number Diff line number Diff line
@@ -212,9 +212,9 @@ isar_load_firmware(struct IsdnCardState *cs, u_char __user *buf) 
	cs->debug &= ~(L1_DEB_HSCX | L1_DEB_HSCX_FIFO);

#endif

	

	if ((ret = copy_from_user(&size, p, sizeof(int)))) {

	if (copy_from_user(&size, p, sizeof(int))) {

		printk(KERN_ERR"isar_load_firmware copy_from_user ret %d\n", ret);

		return ret;

		return -EFAULT;

	}

	p += sizeof(int);

	printk(KERN_DEBUG"isar_load_firmware size: %d\n", size);