Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 36502d02 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda - Fix NULL dereference in snd_hda_gen_build_controls()



When no controls are assigned in the parser (e.g. no analog path),
spec->kctls.list is still NULL.  We need to check it before passing to
snd_hda_add_new_ctls().

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 9eb413e5
Loading
Loading
Loading
Loading
+5 −3
Original line number Diff line number Diff line
@@ -2906,9 +2906,11 @@ int snd_hda_gen_build_controls(struct hda_codec *codec)
	struct hda_gen_spec *spec = codec->spec;
	int err;

	if (spec->kctls.used) {
		err = snd_hda_add_new_ctls(codec, spec->kctls.list);
		if (err < 0)
			return err;
	}

	if (spec->multiout.dig_out_nid) {
		err = snd_hda_create_dig_out_ctls(codec,