Commit 3610a2ad authored May 19, 2016 by Mike Danese Committed by Jonathan Corbet Jun 03, 2016

mpssd: fix buffer overflow warning



The compilation emits a warning in function ‘snprintf’,
    inlined from ‘set_cmdline’ at
    ../Documentation/mic/mpssd/mpssd.c:1541:9:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10:
    warning: call to __builtin___snprintf_chk will always overflow
    destination buffer

This was introduced in commit f4a66c20 ("misc: mic: Update MIC host
daemon with COSM changes") and is fixed by reverting the changes to the
size argument of these snprintf statements.

Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Signed-off-by: Mike Danese <mikedanese@google.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>

parent fac8434d

Documentation/mic/mpssd/mpssd.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1538,9 +1538,9 @@ set_cmdline(struct mic_info *mic)

		len = snprintf(buffer, PATH_MAX,
		"clocksource=tsc highres=off nohz=off ");
		len += snprintf(buffer + len, PATH_MAX,
		len += snprintf(buffer + len, PATH_MAX - len,
		"cpufreq_on;corec6_off;pc3_off;pc6_off ");
		len += snprintf(buffer + len, PATH_MAX,
		len += snprintf(buffer + len, PATH_MAX - len,
		"ifcfg=static;address,172.31.%d.1;netmask,255.255.255.0",
		mic->id + 1);