Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3598aad5 authored by Fabio Estevam's avatar Fabio Estevam Committed by Mark Brown
Browse files

ASoC: wm8731: Use devm_regulator_bulk_get() 



Using devm_regulator_bulk_get() can make the code cleaner and smaller as we
do not need to call regulator_bulk_free() in the error and remove paths.

Signed-off-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent c9eaa447

sound/soc/codecs/wm8731.c

+2 −5
Original line number Diff line number Diff line
@@ -586,7 +586,7 @@ static int wm8731_probe(struct snd_soc_codec *codec) 
	for (i = 0; i < ARRAY_SIZE(wm8731->supplies); i++)

		wm8731->supplies[i].supply = wm8731_supply_names[i];



	ret = regulator_bulk_get(codec->dev, ARRAY_SIZE(wm8731->supplies),

	ret = devm_regulator_bulk_get(codec->dev, ARRAY_SIZE(wm8731->supplies),

				 wm8731->supplies);

	if (ret != 0) {

		dev_err(codec->dev, "Failed to request supplies: %d\n", ret);
@@ -597,7 +597,7 @@ static int wm8731_probe(struct snd_soc_codec *codec) 
				    wm8731->supplies);

	if (ret != 0) {

		dev_err(codec->dev, "Failed to enable supplies: %d\n", ret);

		goto err_regulator_get;

		return ret;

	}



	ret = wm8731_reset(codec);
@@ -624,8 +624,6 @@ static int wm8731_probe(struct snd_soc_codec *codec) 


err_regulator_enable:

	regulator_bulk_disable(ARRAY_SIZE(wm8731->supplies), wm8731->supplies);

err_regulator_get:

	regulator_bulk_free(ARRAY_SIZE(wm8731->supplies), wm8731->supplies);



	return ret;

}
@@ -638,7 +636,6 @@ static int wm8731_remove(struct snd_soc_codec *codec) 
	wm8731_set_bias_level(codec, SND_SOC_BIAS_OFF);



	regulator_bulk_disable(ARRAY_SIZE(wm8731->supplies), wm8731->supplies);

	regulator_bulk_free(ARRAY_SIZE(wm8731->supplies), wm8731->supplies);



	return 0;

}