Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3539699c authored by Phil Reid's avatar Phil Reid Committed by Linus Walleij
Browse files

gpio: mcp23s08: Fix clearing of interrupt. 



The mcp23s18 is configurable on clearing the interrupt on either reading
INTCAP or GPIO. Since driver reads INTCAP in IRQ and not the GPIO reg need
to set control byte for this mode.

Signed-off-by: default avatarPhil Reid <preid@electromag.com.au>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 1cfab8f8

drivers/gpio/gpio-mcp23s08.c

+4 −0
Original line number Diff line number Diff line
@@ -49,6 +49,7 @@ 
#	define IOCON_HAEN	(1 << 3)

#	define IOCON_ODR	(1 << 2)

#	define IOCON_INTPOL	(1 << 1)

#	define IOCON_INTCC	(1)

#define MCP_GPPU	0x06

#define MCP_INTF	0x07

#define MCP_INTCAP	0x08
@@ -680,6 +681,9 @@ static int mcp23s08_probe_one(struct mcp23s08 *mcp, struct device *dev, 
		if (mirror)

			status |= IOCON_MIRROR | (IOCON_MIRROR << 8);



		if (type == MCP_TYPE_S18)

			status |= IOCON_INTCC | (IOCON_INTCC << 8);



		status = mcp->ops->write(mcp, MCP_IOCON, status);

		if (status < 0)

			goto fail;