Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 353471a6 authored by Sebastien Buisson's avatar Sebastien Buisson Committed by Greg Kroah-Hartman
Browse files

staging/lustre: fix 'code maintainability' errors 



Fix 'code maintainability' issues found by Coverity version 6.5.1:
Unused pointer value (UNUSED_VALUE)
Pointer returned by function is never used.
Missing varargs init or cleanup (VARARGS)
va_end was not called for variable.

Signed-off-by: default avatarSebastien Buisson <sebastien.buisson@bull.net>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3107
Lustre-change: http://review.whamcloud.com/5944


Reviewed-by: default avatarDmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: default avatarJohn Hammond <johnlockwoodhammond@gmail.com>
Reviewed-by: default avatarAndreas Dilger <andreas.dilger@intel.com>
Signed-off-by: default avatarPeng Tao <tao.peng@emc.com>
Signed-off-by: default avatarAndreas Dilger <andreas.dilger@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bc06a678

drivers/staging/lustre/lustre/obdclass/lprocfs_jobstats.c

+0 −2
Original line number Diff line number Diff line
@@ -366,7 +366,6 @@ static int lprocfs_jobstats_seq_show(struct seq_file *p, void *v) 
	struct job_stat			*job = v;

	struct lprocfs_stats		*s;

	struct lprocfs_counter		ret;

	struct lprocfs_counter		*cntr;

	struct lprocfs_counter_header	*cntr_header;

	int				i;
@@ -380,7 +379,6 @@ static int lprocfs_jobstats_seq_show(struct seq_file *p, void *v) 


	s = job->js_stats;

	for (i = 0; i < s->ls_num; i++) {

		cntr = lprocfs_stats_counter_get(s, 0, i);

		cntr_header = &s->ls_cnt_header[i];

		lprocfs_stats_collect(s, i, &ret);

drivers/staging/lustre/lustre/ptlrpc/pack_generic.c

+1 −0
Original line number Diff line number Diff line
@@ -2462,6 +2462,7 @@ void _debug_req(struct ptlrpc_request *req, 
			   rep_ok ? lustre_msg_get_flags(req->rq_repmsg) : -1,

			   req->rq_status,

			   rep_ok ? lustre_msg_get_status(req->rq_repmsg) : -1);

	va_end(args);

}

EXPORT_SYMBOL(_debug_req);