Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3510e7a7 authored by Chen-Yu Tsai's avatar Chen-Yu Tsai Committed by Sean Paul
Browse files

drm/sun4i: Remove R40 display pipeline compatibles 



Two patches from the R40 display pipeline support series weren't applied
with the rest of the series. When they did get applied, the -rc6
deadline for drm-misc-next had past, so they didn't get into 4.19-rc1
with the rest of the series. However, the two patches are crucial in
the parsing of the R40's display pipeline graph in the device tree.
Without them, the driver crashes because it can't follow the odd graph
structure.

This patch removes the R40 compatibles from the sun4i-drm driver,
effectively disabling DRM support for the R40 for one release cycle.
This will prevent the driver from crashing upon probing.

The compatibles should be reinstated for the next release.

Signed-off-by: default avatarChen-Yu Tsai <wens@csie.org>
Signed-off-by: default avatarMaxime Ripard <maxime.ripard@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180827083950.602-1-wens@csie.org


Signed-off-by: default avatarSean Paul <seanpaul@chromium.org>
parent 7eb33224

drivers/gpu/drm/sun4i/sun4i_drv.c

+0 −1
Original line number Diff line number Diff line
@@ -418,7 +418,6 @@ static const struct of_device_id sun4i_drv_of_table[] = { 
	{ .compatible = "allwinner,sun8i-a33-display-engine" },

	{ .compatible = "allwinner,sun8i-a83t-display-engine" },

	{ .compatible = "allwinner,sun8i-h3-display-engine" },

	{ .compatible = "allwinner,sun8i-r40-display-engine" },

	{ .compatible = "allwinner,sun8i-v3s-display-engine" },

	{ .compatible = "allwinner,sun9i-a80-display-engine" },

	{ }

drivers/gpu/drm/sun4i/sun8i_mixer.c

+0 −24
Original line number Diff line number Diff line
@@ -545,22 +545,6 @@ static const struct sun8i_mixer_cfg sun8i_h3_mixer0_cfg = { 
	.vi_num		= 1,

};



static const struct sun8i_mixer_cfg sun8i_r40_mixer0_cfg = {

	.ccsc		= 0,

	.mod_rate	= 297000000,

	.scaler_mask	= 0xf,

	.ui_num		= 3,

	.vi_num		= 1,

};



static const struct sun8i_mixer_cfg sun8i_r40_mixer1_cfg = {

	.ccsc		= 1,

	.mod_rate	= 297000000,

	.scaler_mask	= 0x3,

	.ui_num		= 1,

	.vi_num		= 1,

};



static const struct sun8i_mixer_cfg sun8i_v3s_mixer_cfg = {

	.vi_num = 2,

	.ui_num = 1,
@@ -582,14 +566,6 @@ static const struct of_device_id sun8i_mixer_of_table[] = { 
		.compatible = "allwinner,sun8i-h3-de2-mixer-0",

		.data = &sun8i_h3_mixer0_cfg,

	},

	{

		.compatible = "allwinner,sun8i-r40-de2-mixer-0",

		.data = &sun8i_r40_mixer0_cfg,

	},

	{

		.compatible = "allwinner,sun8i-r40-de2-mixer-1",

		.data = &sun8i_r40_mixer1_cfg,

	},

	{

		.compatible = "allwinner,sun8i-v3s-de2-mixer",

		.data = &sun8i_v3s_mixer_cfg,

drivers/gpu/drm/sun4i/sun8i_tcon_top.c

+0 −1
Original line number Diff line number Diff line
@@ -253,7 +253,6 @@ static int sun8i_tcon_top_remove(struct platform_device *pdev) 


/* sun4i_drv uses this list to check if a device node is a TCON TOP */

const struct of_device_id sun8i_tcon_top_of_table[] = {

	{ .compatible = "allwinner,sun8i-r40-tcon-top" },

	{ /* sentinel */ }

};

MODULE_DEVICE_TABLE(of, sun8i_tcon_top_of_table);