Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 34ad1296 authored by Michal Hocko's avatar Michal Hocko Committed by Linus Torvalds
Browse files

mm, memory_hotplug: remove explicit build_all_zonelists from try_online_node 

try_online_node calls hotadd_new_pgdat which already calls
build_all_zonelists.  So the additional call is redundant.  Even though
hotadd_new_pgdat will only initialize zonelists of the new node this is
the right thing to do because such a node doesn't have any memory so
other zonelists would ignore all the zones from this node anyway.

Link: http://lkml.kernel.org/r/20170721143915.14161-6-mhocko@kernel.org


Signed-off-by: default avatarMichal Hocko <mhocko@suse.com>
Acked-by: default avatarVlastimil Babka <vbabka@suse.cz>
Cc: Toshi Kani <toshi.kani@hpe.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Joonsoo Kim <js1304@gmail.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Shaohua Li <shaohua.li@intel.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 72675e13

mm/memory_hotplug.c

+0 −7
Original line number Diff line number Diff line
@@ -1081,13 +1081,6 @@ int try_online_node(int nid) 
	node_set_online(nid);

	ret = register_one_node(nid);

	BUG_ON(ret);



	if (pgdat->node_zonelists->_zonerefs->zone == NULL) {

		mutex_lock(&zonelists_mutex);

		build_all_zonelists(NULL);

		mutex_unlock(&zonelists_mutex);

	}



out:

	mem_hotplug_done();

	return ret;