Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 345fef75 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Mark Brown
Browse files

spi: spi-sh: fix error return code in spi_sh_probe() 



platform_get_irq() returns an error code, but the spi-sh driver
ignores it and always returns -ENODEV. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.

Print and propagate the return value of platform_get_irq on failure.

This issue was detected with the help of Coccinelle.

Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 5771a8c0

drivers/spi/spi-sh.c

+2 −2
Original line number Diff line number Diff line
@@ -446,8 +446,8 @@ static int spi_sh_probe(struct platform_device *pdev) 


	irq = platform_get_irq(pdev, 0);

	if (irq < 0) {

		dev_err(&pdev->dev, "platform_get_irq error\n");

		return -ENODEV;

		dev_err(&pdev->dev, "platform_get_irq error: %d\n", irq);

		return irq;

	}



	master = spi_alloc_master(&pdev->dev, sizeof(struct spi_sh_data));