Commit 345c7757 authored Jan 25, 2019 by Nicholas Kazlauskas Committed by Greg Kroah-Hartman Apr 05, 2019

drm/amd/display: Clear stream->mode_changed after commit



[ Upstream commit d8d2f174bcc2c26c3485c70e0c6fe22b27bce739 ]

[Why]
The stream->mode_changed flag can persist in the following sequence
of atomic commits:

Commit 1:
Enable CRTC0 (mode_changed = true), Enable CRTC1 (mode_changed = true)

Commit 2:
Disable CRTC1 (mode_changed = false)

In this sequence we want to keep the exiting CRTC0 but it's not in the
atomic state for the commit since it hasn't been modified. In this case
the stream->mode_changed flag persists as true and we don't re-program
the planes for the existing stream.

[How]
The flag needs to be cleared and it makes the most sense to do it within
DC after the state has been committed. Nothing following dc_commit_state
should think that the stream's mode has changed.

Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Reviewed-by: Leo Li <sunpeng.li@amd.com>
Acked-by: Tony Cheng <Tony.Cheng@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 1ef1b20f

drivers/gpu/drm/amd/display/dc/core/dc.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -958,6 +958,9 @@ static enum dc_status dc_commit_state_no_check(struct dc dc, struct dc_state c
		/* pplib is notified if disp_num changed */
		dc->hwss.set_bandwidth(dc, context, true);

		for (i = 0; i < context->stream_count; i++)
		context->streams[i]->mode_changed = false;

		dc_release_state(dc->current_state);

		dc->current_state = context;