Commit 33f0698a authored Jan 25, 2017 by Arnd Bergmann Committed by Mark Brown Jan 26, 2017

regulator: s2mpa01: reduce stack size for probe function



In some rare configurations we can run into rather high kernel stack
consumption:

drivers/regulator/s2mpa01.c:397:1: error: the frame size of 1536 bytes is larger than 1152 bytes [-Werror=frame-larger-than=]

This is probably harmless since it happens only in the probe function,
but there is also a relatively simple workaround, moving the regulator
match data into the device specific structure.

As a small downside, we waste a little memory at runtime. An alternative
approach would free the array at the end of the probe function, which in
turn is a little more complicated.

Fixes: f1879271 ("regulator: Add support for S2MPA01 regulator")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent d00b7461

drivers/regulator/s2mpa01.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -26,6 +26,7 @@
		#define S2MPA01_REGULATOR_CNT ARRAY_SIZE(regulators)

		struct s2mpa01_info {
		struct of_regulator_match rdata[S2MPA01_REGULATOR_MAX];
		int ramp_delay24;
		int ramp_delay3;
		int ramp_delay5;
		@@ -341,9 +342,9 @@ static int s2mpa01_pmic_probe(struct platform_device *pdev)
		{
		struct sec_pmic_dev *iodev = dev_get_drvdata(pdev->dev.parent);
		struct sec_platform_data *pdata = dev_get_platdata(iodev->dev);
		struct of_regulator_match rdata[S2MPA01_REGULATOR_MAX] = { };
		struct device_node *reg_np = NULL;
		struct regulator_config config = { };
		struct of_regulator_match *rdata;
		struct s2mpa01_info *s2mpa01;
		int i;

		@@ -351,6 +352,7 @@ static int s2mpa01_pmic_probe(struct platform_device *pdev)
		if (!s2mpa01)
		return -ENOMEM;

		rdata = s2mpa01->rdata;
		for (i = 0; i < S2MPA01_REGULATOR_CNT; i++)
		rdata[i].name = regulators[i].name;