Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3389c99e authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: dt2801: fix using uninitialized variable warnings 



As pointed out by Fengguang Wu, the calls to dt2801_readdata() return the
data read thru a pointer (the address of a local variable) passed as a
parameter. If this local variable is not initialized it produces a warning
during the build of the form:

drivers/staging/comedi/drivers/dt2801.c: In function 'dt2801_ai_insn_read':
drivers/staging/comedi/drivers/dt2801.c:273:14: warning: 'hb' is used
      uninitialized in this function [-Wuninitialized]

Fix these warning by making sure the local variables are initialized.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reported-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 48c8cd29

drivers/staging/comedi/drivers/dt2801.c

+3 −2
Original line number Diff line number Diff line
@@ -260,7 +260,8 @@ static int dt2801_readdata(struct comedi_device *dev, int *data) 


static int dt2801_readdata2(struct comedi_device *dev, int *data)

{

	int lb, hb;

	int lb = 0;

	int hb = 0;

	int ret;



	ret = dt2801_readdata(dev, &lb);
@@ -532,7 +533,7 @@ static int dt2801_dio_insn_bits(struct comedi_device *dev, 
				unsigned int *data)

{

	int which = (s == &dev->subdevices[3]) ? 1 : 0;

	unsigned int val;

	unsigned int val = 0;



	if (comedi_dio_update_state(s, data)) {

		dt2801_writecmd(dev, DT_C_WRITE_DIG);