Commit 335d4f81 authored Dec 03, 2018 by Daniel T. Lee Committed by Greg Kroah-Hartman Nov 06, 2019

samples: bpf: fix: seg fault with NULL pointer arg



[ Upstream commit d59dd69d5576d699d7d3f5da0b4738c3a36d0133 ]

When NULL pointer accidentally passed to write_kprobe_events,
due to strlen(NULL), segmentation fault happens.
Changed code returns -1 to deal with this situation.

Bug issued with Smatch, static analysis.

Signed-off-by: Daniel T. Lee <danieltimlee@gmail.com>
Acked-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent c41f30e8

samples/bpf/bpf_load.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -59,7 +59,9 @@ static int write_kprobe_events(const char *val)
		{
		int fd, ret, flags;

		if ((val != NULL) && (val[0] == '\0'))
		if (val == NULL)
		return -1;
		else if (val[0] == '\0')
		flags = O_WRONLY \| O_TRUNC;
		else
		flags = O_WRONLY \| O_APPEND;