Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3335f0ca authored by Amerigo Wang's avatar Amerigo Wang Committed by David S. Miller
Browse files

netconsole: do not release spin_lock when calling __netpoll_cleanup 



With the previous patch applied, __netpoll_cleanup() is non-block now,
so we don't need to release the spin_lock before calling it.

Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: default avatarCong Wang <amwang@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 38e6bc18

drivers/net/netconsole.c

+0 −5
Original line number Diff line number Diff line
@@ -640,12 +640,7 @@ static int netconsole_netdev_event(struct notifier_block *this, 
				 * rtnl_lock already held

				 */

				if (nt->np.dev) {

					spin_unlock_irqrestore(

							      &target_list_lock,

							      flags);

					__netpoll_cleanup(&nt->np);

					spin_lock_irqsave(&target_list_lock,

							  flags);

					dev_put(nt->np.dev);

					nt->np.dev = NULL;

					netconsole_target_put(nt);