Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 33023fb8 authored by Steve Wise's avatar Steve Wise Committed by Jason Gunthorpe
Browse files

IB/core: add max_send_sge and max_recv_sge attributes 



This patch replaces the ib_device_attr.max_sge with max_send_sge and
max_recv_sge. It allows ulps to take advantage of devices that have very
different send and recv sge depths.  For example cxgb4 has a max_recv_sge
of 4, yet a max_send_sge of 16.  Splitting out these attributes allows
much more efficient use of the SQ for cxgb4 with ulps that use the RDMA_RW
API. Consider a large RDMA WRITE that has 16 scattergather entries.
With max_sge of 4, the ulp would send 4 WRITE WRs, but with max_sge of
16, it can be done with 1 WRITE WR.

Acked-by: default avatarSagi Grimberg <sagi@grimberg.me>
Acked-by: default avatarChristoph Hellwig <hch@lst.de>
Acked-by: default avatarSelvin Xavier <selvin.xavier@broadcom.com>
Acked-by: default avatarShiraz Saleem <shiraz.saleem@intel.com>
Acked-by: default avatarDennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: default avatarSteve Wise <swise@opengridcomputing.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent b90575ce

drivers/infiniband/core/uverbs_cmd.c

+1 −1
Original line number Diff line number Diff line
@@ -189,7 +189,7 @@ static void copy_query_dev_fields(struct ib_uverbs_file *file, 
	resp->max_qp		= attr->max_qp;

	resp->max_qp_wr		= attr->max_qp_wr;

	resp->device_cap_flags	= lower_32_bits(attr->device_cap_flags);

	resp->max_sge		= attr->max_sge;

	resp->max_sge		= min(attr->max_send_sge, attr->max_recv_sge);

	resp->max_sge_rd	= attr->max_sge_rd;

	resp->max_cq		= attr->max_cq;

	resp->max_cqe		= attr->max_cqe;

drivers/infiniband/hw/bnxt_re/ib_verbs.c

+2 −1
Original line number Diff line number Diff line
@@ -166,7 +166,8 @@ int bnxt_re_query_device(struct ib_device *ibdev, 
				    | IB_DEVICE_MEM_WINDOW

				    | IB_DEVICE_MEM_WINDOW_TYPE_2B

				    | IB_DEVICE_MEM_MGT_EXTENSIONS;

	ib_attr->max_sge = dev_attr->max_qp_sges;

	ib_attr->max_send_sge = dev_attr->max_qp_sges;

	ib_attr->max_recv_sge = dev_attr->max_qp_sges;

	ib_attr->max_sge_rd = dev_attr->max_qp_sges;

	ib_attr->max_cq = dev_attr->max_cq;

	ib_attr->max_cqe = dev_attr->max_cq_wqes;

drivers/infiniband/hw/cxgb3/iwch_provider.c

+2 −1
Original line number Diff line number Diff line
@@ -1103,7 +1103,8 @@ static int iwch_query_device(struct ib_device *ibdev, struct ib_device_attr *pro 
	props->max_mr_size = dev->attr.max_mr_size;

	props->max_qp = dev->attr.max_qps;

	props->max_qp_wr = dev->attr.max_wrs;

	props->max_sge = dev->attr.max_sge_per_wr;

	props->max_send_sge = dev->attr.max_sge_per_wr;

	props->max_recv_sge = dev->attr.max_sge_per_wr;

	props->max_sge_rd = 1;

	props->max_qp_rd_atom = dev->attr.max_rdma_reads_per_qp;

	props->max_qp_init_rd_atom = dev->attr.max_rdma_reads_per_qp;

drivers/infiniband/hw/cxgb4/provider.c

+2 −1
Original line number Diff line number Diff line
@@ -343,7 +343,8 @@ static int c4iw_query_device(struct ib_device *ibdev, struct ib_device_attr *pro 
	props->max_mr_size = T4_MAX_MR_SIZE;

	props->max_qp = dev->rdev.lldi.vr->qp.size / 2;

	props->max_qp_wr = dev->rdev.hw_queue.t4_max_qp_depth;

	props->max_sge = T4_MAX_RECV_SGE;

	props->max_send_sge = min(T4_MAX_SEND_SGE, T4_MAX_WRITE_SGE);

	props->max_recv_sge = T4_MAX_RECV_SGE;

	props->max_sge_rd = 1;

	props->max_res_rd_atom = dev->rdev.lldi.max_ird_adapter;

	props->max_qp_rd_atom = min(dev->rdev.lldi.max_ordird_qp,

drivers/infiniband/hw/hfi1/verbs.c

+2 −1
Original line number Diff line number Diff line
@@ -1410,7 +1410,8 @@ static void hfi1_fill_device_attr(struct hfi1_devdata *dd) 
	rdi->dparms.props.max_fast_reg_page_list_len = UINT_MAX;

	rdi->dparms.props.max_qp = hfi1_max_qps;

	rdi->dparms.props.max_qp_wr = hfi1_max_qp_wrs;

	rdi->dparms.props.max_sge = hfi1_max_sges;

	rdi->dparms.props.max_send_sge = hfi1_max_sges;

	rdi->dparms.props.max_recv_sge = hfi1_max_sges;

	rdi->dparms.props.max_sge_rd = hfi1_max_sges;

	rdi->dparms.props.max_cq = hfi1_max_cqs;

	rdi->dparms.props.max_ah = hfi1_max_ahs;