Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 32fe6142 authored by Takashi Iwai's avatar Takashi Iwai Committed by Jaroslav Kysela
Browse files

ALSA: mtpav - Fix race in probe 



Ingo reported Oops at probing mtpav driver.  It's a race between
the irq handler and the rawmidi instance registration.

This patch fixes the order of registration to avoid the race.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Tested-by: default avatarIngo Molnar <mingo@elte.hu>
Signed-off-by: default avatarJaroslav Kysela <perex@perex.cz>
parent 59b3db6c

sound/drivers/mtpav.c

+4 −4
Original line number Diff line number Diff line
@@ -715,6 +715,10 @@ static int __devinit snd_mtpav_probe(struct platform_device *dev) 


	card->private_free = snd_mtpav_free;



	err = snd_mtpav_get_RAWMIDI(mtp_card);

	if (err < 0)

		goto __error;



	err = snd_mtpav_get_ISA(mtp_card);

	if (err < 0)

		goto __error;
@@ -724,10 +728,6 @@ static int __devinit snd_mtpav_probe(struct platform_device *dev) 
	snprintf(card->longname, sizeof(card->longname),

		 "MTPAV on parallel port at 0x%lx", port);



	err = snd_mtpav_get_RAWMIDI(mtp_card);

	if (err < 0)

		goto __error;



	snd_mtpav_portscan(mtp_card);



	snd_card_set_dev(card, &dev->dev);