Commit 32a24a39 authored May 26, 2019 by Gen Zhang Committed by Greg Kroah-Hartman Dec 05, 2019

powerpc/pseries/dlpar: Fix a missing check in dlpar_parse_cc_property()



[ Upstream commit efa9ace68e487ddd29c2b4d6dd23242158f1f607 ]

In dlpar_parse_cc_property(), 'prop->name' is allocated by kstrdup().
kstrdup() may return NULL, so it should be checked and handle error.
And prop should be freed if 'prop->name' is NULL.

Signed-off-by: Gen Zhang <blackgod016574@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 123b9510

arch/powerpc/platforms/pseries/dlpar.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -63,6 +63,10 @@ static struct property dlpar_parse_cc_property(struct cc_workarea ccwa)

		name = (char *)ccwa + be32_to_cpu(ccwa->name_offset);
		prop->name = kstrdup(name, GFP_KERNEL);
		if (!prop->name) {
		dlpar_free_cc_property(prop);
		return NULL;
		}

		prop->length = be32_to_cpu(ccwa->prop_length);
		value = (char *)ccwa + be32_to_cpu(ccwa->prop_offset);