Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 32643988 authored by Yuval Mintz's avatar Yuval Mintz Committed by David S. Miller
Browse files

qed: Prevent VF from Tx-switching 'promisc' 



Internal loopback in driver is based on two things - first
is the willingness of transmitter to use it [in case of VFs,
this can be forced based on VEPA/VEB] and secondly on another
vport classification configuration which should match the
packet's destination.

Current code allows non-linux VFs to configure a 'promisc'
mode on Tx, meaning all traffic sent by VF would be loopbacked
internally by firmware; This isn't considered a valid mode and
as such should be prevented by PF.

Signed-off-by: default avatarYuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e6bd8923

drivers/net/ethernet/qlogic/qed/qed_l2.c

+0 −4
Original line number Diff line number Diff line
@@ -248,10 +248,6 @@ qed_sp_update_accept_mode(struct qed_hwfn *p_hwfn, 
		SET_FIELD(state, ETH_VPORT_TX_MODE_UCAST_DROP_ALL,

			  !!(accept_filter & QED_ACCEPT_NONE));



		SET_FIELD(state, ETH_VPORT_TX_MODE_UCAST_ACCEPT_ALL,

			  (!!(accept_filter & QED_ACCEPT_UCAST_MATCHED) &&

			   !!(accept_filter & QED_ACCEPT_UCAST_UNMATCHED)));



		SET_FIELD(state, ETH_VPORT_TX_MODE_MCAST_DROP_ALL,

			  !!(accept_filter & QED_ACCEPT_NONE));