Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 320f1a4a authored by Sasha Levin's avatar Sasha Levin Committed by David S. Miller
Browse files

net: sctp: prevent writes to cookie_hmac_alg from accessing invalid memory 



proc_dostring() needs an initialized destination string, while the one
provided in proc_sctp_do_hmac_alg() contains stack garbage.

Thus, writing to cookie_hmac_alg would strlen() that garbage and end up
accessing invalid memory.

Fixes: 3c68198e ("sctp: Make hmac algorithm selection for cookie generation dynamic")
Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 18715b26

net/sctp/sysctl.c

+1 −1
Original line number Diff line number Diff line
@@ -320,7 +320,7 @@ static int proc_sctp_do_hmac_alg(struct ctl_table *ctl, int write, 
	struct ctl_table tbl;

	bool changed = false;

	char *none = "none";

	char tmp[8];

	char tmp[8] = {0};

	int ret;



	memset(&tbl, 0, sizeof(struct ctl_table));