Commit 3208795e authored Nov 07, 2012 by Selvan Mani Committed by Jens Axboe Nov 23, 2012

mtip32xx: fix potential crash on SEC_ERASE_UNIT



The mtip driver lifted this code from elsewhere and then added a special
handling check for SEC_ERASE_UNIT. If the caller tries to do a security
erase but passes no output data for the command then outbuf is not
allocated and the driver duly explodes.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Selvan Mani <smani@micron.com>
Signed-off-by: Asai Thambi S P <asamymuthupa@micron.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent a8c32a5c

drivers/block/mtip32xx/mtip32xx.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -2218,8 +2218,8 @@ static int exec_drive_taskfile(struct driver_data *dd,
		fis.device);

		/* check for erase mode support during secure erase.*/
		if ((fis.command == ATA_CMD_SEC_ERASE_UNIT)
		&& (outbuf[0] & MTIP_SEC_ERASE_MODE)) {
		if ((fis.command == ATA_CMD_SEC_ERASE_UNIT) && outbuf &&
		(outbuf[0] & MTIP_SEC_ERASE_MODE)) {
		erasemode = 1;
		}