Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 31efcc25 authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller
Browse files

net/sched: properly assign RCU pointer in tcf_chain_tp_insert/remove 



*p_filter_chain is rcu-dereferenced on reader path. So here in writer,
property assign the pointer.

Fixes: 2190d1d0 ("net: sched: introduce helpers to work with filter chains")
Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 218b6a5b

net/sched/cls_api.c

+2 −2
Original line number Diff line number Diff line
@@ -351,7 +351,7 @@ static void tcf_chain_tp_insert(struct tcf_chain *chain, 
{

	if (chain->p_filter_chain &&

	    *chain_info->pprev == chain->filter_chain)

		*chain->p_filter_chain = tp;

		rcu_assign_pointer(*chain->p_filter_chain, tp);

	RCU_INIT_POINTER(tp->next, tcf_chain_tp_prev(chain_info));

	rcu_assign_pointer(*chain_info->pprev, tp);

}
@@ -363,7 +363,7 @@ static void tcf_chain_tp_remove(struct tcf_chain *chain, 
	struct tcf_proto *next = rtnl_dereference(chain_info->next);



	if (chain->p_filter_chain && tp == chain->filter_chain)

		*chain->p_filter_chain = next;

		RCU_INIT_POINTER(*chain->p_filter_chain, next);

	RCU_INIT_POINTER(*chain_info->pprev, next);

}