Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 31ce54f6 authored by Sylwester Nawrocki's avatar Sylwester Nawrocki Committed by Mauro Carvalho Chehab
Browse files

[media] s5p-fimc: Use switch statement for better readability 



Use switch statement rather than multiple 'else if'.

Signed-off-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent a516d08f

drivers/media/video/s5p-fimc/fimc-reg.c

+8 −6
Original line number Diff line number Diff line
@@ -667,7 +667,8 @@ int fimc_hw_set_camera_type(struct fimc_dev *fimc, 
		FIMC_REG_CIGCTRL_SELCAM_MIPI | FIMC_REG_CIGCTRL_CAMIF_SELWB |

		FIMC_REG_CIGCTRL_SELCAM_MIPI_A | FIMC_REG_CIGCTRL_CAM_JPEG);



	if (cam->bus_type == FIMC_MIPI_CSI2) {

	switch (cam->bus_type) {

	case FIMC_MIPI_CSI2:

		cfg |= FIMC_REG_CIGCTRL_SELCAM_MIPI;



		if (cam->mux_id == 0)
@@ -691,14 +692,15 @@ int fimc_hw_set_camera_type(struct fimc_dev *fimc, 
		tmp |= (csis_data_alignment == 32) << 8;



		writel(tmp, fimc->regs + FIMC_REG_CSIIMGFMT);



	} else if (cam->bus_type == FIMC_ITU_601 ||

		   cam->bus_type == FIMC_ITU_656) {

		break;

	case FIMC_ITU_601...FIMC_ITU_656:

		if (cam->mux_id == 0) /* ITU-A, ITU-B: 0, 1 */

			cfg |= FIMC_REG_CIGCTRL_SELCAM_ITU_A;

	} else if (cam->bus_type == FIMC_LCD_WB) {

		break;

	case FIMC_LCD_WB:

		cfg |= FIMC_REG_CIGCTRL_CAMIF_SELWB;

	} else {

		break;

	default:

		v4l2_err(vid_cap->vfd, "Invalid camera bus type selected\n");

		return -EINVAL;

	}