Commit 31ca5878 authored Oct 13, 2016 by Geert Uytterhoeven Committed by Ilya Dryomov Oct 18, 2016

ceph: fix uninitialized dentry pointer in ceph_real_mount()



    fs/ceph/super.c: In function ‘ceph_real_mount’:
    fs/ceph/super.c:818: warning: ‘root’ may be used uninitialized in this function

If s_root is already valid, dentry pointer root is never initialized,
and returned by ceph_real_mount(). This will cause a crash later when
the caller dereferences the pointer.

Fixes: ce2728aa ("ceph: avoid accessing / when mounting a subpath")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Yan, Zheng <zyan@redhat.com>

parent f72f9455

fs/ceph/super.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -845,6 +845,8 @@ static struct dentry ceph_real_mount(struct ceph_fs_client fsc)
		err = ceph_fs_debugfs_init(fsc);
		if (err < 0)
		goto fail;
		} else {
		root = dget(fsc->sb->s_root);
		}

		fsc->mount_state = CEPH_MOUNT_MOUNTED;