Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3130451e authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Ingo Molnar
Browse files

x86/platform/atom: Re-use DEFINE_SHOW_ATTRIBUTE() macro 



...instead of open coding file operations followed by custom ->open()
callbacks per each attribute.

While here, replace permissions by explicit octal value.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20180214154317.52290-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent e525de3a

arch/x86/platform/atom/punit_atom_debug.c

+3 −14
Original line number Diff line number Diff line
@@ -109,18 +109,7 @@ static int punit_dev_state_show(struct seq_file *seq_file, void *unused) 


	return 0;

}



static int punit_dev_state_open(struct inode *inode, struct file *file)

{

	return single_open(file, punit_dev_state_show, inode->i_private);

}



static const struct file_operations punit_dev_state_ops = {

	.open		= punit_dev_state_open,

	.read		= seq_read,

	.llseek		= seq_lseek,

	.release	= single_release,

};

DEFINE_SHOW_ATTRIBUTE(punit_dev_state);



static struct dentry *punit_dbg_file;
@@ -132,9 +121,9 @@ static int punit_dbgfs_register(struct punit_device *punit_device) 
	if (!punit_dbg_file)

		return -ENXIO;



	dev_state = debugfs_create_file("dev_power_state", S_IFREG | S_IRUGO,

	dev_state = debugfs_create_file("dev_power_state", 0444,

					punit_dbg_file, punit_device,

					&punit_dev_state_ops);

					&punit_dev_state_fops);

	if (!dev_state) {

		pr_err("punit_dev_state register failed\n");

		debugfs_remove(punit_dbg_file);