Commit 31279b14 authored Dec 17, 2012 by Dan Carpenter Committed by Linus Torvalds Dec 17, 2012

aoe: fix use after free in aoedev_by_aoeaddr()



We should return NULL on failure instead of returning a freed pointer.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ed Cashin <ecashin@coraid.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 2b37c7d8

drivers/block/aoe/aoedev.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -461,6 +461,7 @@ aoedev_by_aoeaddr(ulong maj, int min, int do_alloc)
		d->targets = kcalloc(NTARGETS, sizeof(*d->targets), GFP_ATOMIC);
		if (!d->targets) {
		kfree(d);
		d = NULL;
		goto out;
		}
		d->ntargets = NTARGETS;