Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 308e3e0b authored by John Hsu's avatar John Hsu Committed by Mark Brown
Browse files

ASoC: nau8825: drop redundant idiom when converting integer to boolean 



Thanks Mark and Anatol for the discussion. According to the result,
the standard C will translate any non-zero value into true, or
false otherwise.
QUOTE:
"6.3.1.2 Boolean type
When any scalar value is converted to _Bool, the result is 0 if the
value compares equal to 0; otherwise, the result is 1
"
Thus, the "!!" idiom is removed.

Signed-off-by: default avatarJohn Hsu <KCHSU0@nuvoton.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent bff03e81

sound/soc/codecs/nau8825.c

+2 −2
Original line number Diff line number Diff line
@@ -1349,9 +1349,9 @@ static bool nau8825_is_jack_inserted(struct regmap *regmap) 
	int status, jkdet;



	regmap_read(regmap, NAU8825_REG_JACK_DET_CTRL, &jkdet);

	active_high = !!(jkdet & NAU8825_JACK_POLARITY);

	active_high = jkdet & NAU8825_JACK_POLARITY;

	regmap_read(regmap, NAU8825_REG_I2C_DEVICE_ID, &status);

	is_high = !!(status & NAU8825_GPIO2JD1);

	is_high = status & NAU8825_GPIO2JD1;

	/* return jack connection status according to jack insertion logic

	 * active high or active low.

	 */