Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 307fdf5e authored by Allan Stephens's avatar Allan Stephens Committed by David S. Miller
Browse files

tipc: Add missing spinlock in name table display code 



This patch ensures that the display code that traverses the
publication lists belonging to a name table entry take its
associated spinlock, to protect against a possible change to
one of its "head of list" pointers caused by a simultaneous
name table lookup operation by another thread of control.

Signed-off-by: default avatarAllan Stephens <allan.stephens@windriver.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0f15d364

net/tipc/name_table.c

+3 −1
Original line number Diff line number Diff line
@@ -74,7 +74,7 @@ struct sub_seq { 
 * @first_free: array index of first unused sub-sequence entry

 * @ns_list: links to adjacent name sequences in hash chain

 * @subscriptions: list of subscriptions for this 'type'

 * @lock: spinlock controlling access to name sequence structure

 * @lock: spinlock controlling access to publication lists of all sub-sequences

 */



struct name_seq {
@@ -918,7 +918,9 @@ static void nameseq_list(struct name_seq *seq, struct print_buf *buf, u32 depth, 
	for (sseq = seq->sseqs; sseq != &seq->sseqs[seq->first_free]; sseq++) {

		if ((lowbound <= sseq->upper) && (upbound >= sseq->lower)) {

			tipc_printf(buf, "%s ", typearea);

			spin_lock_bh(&seq->lock);

			subseq_list(sseq, buf, depth, index);

			spin_unlock_bh(&seq->lock);

			sprintf(typearea, "%10s", " ");

		}

	}