Commit 305a6f38 authored Jan 10, 2013 by H Hartley Sweeten Committed by Greg Kroah-Hartman Jan 17, 2013

staging: comedi: comedi_buf: remove BUG_ON in comedi_buf_munge()



The condition that would trigger this BUG_ON can never occur.

The 'munge_count' will be equal to 'buf_write_count' if all the data
in the buffer has been munged.

Or, the 'munge_count' will be less than the 'buf_write_count' if any
partial samples in the buffer were not munged.

The 'munge_count' will never be greater than the 'buf_write_count'.

Remove the unnecessary BUG_ON.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbobbi@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8ae560a1

drivers/staging/comedi/comedi_buf.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -245,7 +245,6 @@ static unsigned int comedi_buf_munge(struct comedi_async *async,
		}
		}

		BUG_ON((int)(async->munge_count - async->buf_write_count) > 0);
		return count;
		}