Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 30587535 authored by Kees Cook's avatar Kees Cook Committed by Daniel Vetter
Browse files

drm/i915: clarify reasoning for the access_ok call 



This clarifies the comment above the access_ok check so a missing
VERIFY_READ doesn't alarm anyone.

v2:
 - rewrote comment, thanks to Chris Wilson

Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
[danvet: add patch history log to commit message.]
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 647416f9

drivers/gpu/drm/i915/i915_gem_execbuffer.c

+5 −1
Original line number Diff line number Diff line
@@ -747,7 +747,11 @@ validate_exec_list(struct drm_i915_gem_exec_object2 *exec, 


		length = exec[i].relocation_count *

			sizeof(struct drm_i915_gem_relocation_entry);

		/* we may also need to update the presumed offsets */

		/*

		 * We must check that the entire relocation array is safe

		 * to read, but since we may need to update the presumed

		 * offsets during execution, check for full write access.

		 */

		if (!access_ok(VERIFY_WRITE, ptr, length))

			return -EFAULT;