Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 301cdc22 authored by Trond Myklebust's avatar Trond Myklebust Committed by Greg Kroah-Hartman
Browse files

NFSv42: Don't fail clone() unless the OP_CLONE operation failed 



[ Upstream commit d3c45824ad65aebf765fcf51366d317a29538820 ]

The failure to retrieve post-op attributes has no bearing on whether or
not the clone operation itself was successful. We must therefore ignore
the return value of decode_getfattr() when looking at the success or
failure of nfs4_xdr_dec_clone().

Fixes: 36022770 ("nfs42: add CLONE xdr functions")
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent b03c7892

fs/nfs/nfs42xdr.c

+1 −2
Original line number Diff line number Diff line
@@ -707,8 +707,7 @@ static int nfs4_xdr_dec_clone(struct rpc_rqst *rqstp, 
	status = decode_clone(xdr);

	if (status)

		goto out;

	status = decode_getfattr(xdr, res->dst_fattr, res->server);



	decode_getfattr(xdr, res->dst_fattr, res->server);

out:

	res->rpc_status = status;

	return status;