Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2ff78c0c authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: ir-usb: fix double free 



If the user specifies a custom bulk buffer size we get a double free at
port release.

Cc: stable <stable@kernel.org>
Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 16032c4f

drivers/usb/serial/ir-usb.c

+2 −0
Original line number Diff line number Diff line
@@ -312,6 +312,7 @@ static int ir_open(struct tty_struct *tty, struct usb_serial_port *port) 
		kfree(port->read_urb->transfer_buffer);

		port->read_urb->transfer_buffer = buffer;

		port->read_urb->transfer_buffer_length = buffer_size;

		port->bulk_in_buffer = buffer;



		buffer = kmalloc(buffer_size, GFP_KERNEL);

		if (!buffer) {
@@ -321,6 +322,7 @@ static int ir_open(struct tty_struct *tty, struct usb_serial_port *port) 
		kfree(port->write_urb->transfer_buffer);

		port->write_urb->transfer_buffer = buffer;

		port->write_urb->transfer_buffer_length = buffer_size;

		port->bulk_out_buffer = buffer;

		port->bulk_out_size = buffer_size;

	}