Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2faf2657 authored by Karim Eshapa's avatar Karim Eshapa Committed by David S. Miller
Browse files

benet: Use time_before_eq for time comparison 



Use time_before_eq for time comparison more safe and dealing
with timer wrapping to be future-proof.

Signed-off-by: default avatarKarim Eshapa <karim.eshapa@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1a7fca63

drivers/net/ethernet/emulex/benet/be_main.c

+3 −3
Original line number Diff line number Diff line
@@ -5268,15 +5268,15 @@ static bool be_err_is_recoverable(struct be_adapter *adapter) 
	dev_err(&adapter->pdev->dev, "Recoverable HW error code: 0x%x\n",

		ue_err_code);



	if (jiffies - err_rec->probe_time <= initial_idle_time) {

	if (time_before_eq(jiffies - err_rec->probe_time, initial_idle_time)) {

		dev_err(&adapter->pdev->dev,

			"Cannot recover within %lu sec from driver load\n",

			jiffies_to_msecs(initial_idle_time) / MSEC_PER_SEC);

		return false;

	}



	if (err_rec->last_recovery_time &&

	    (jiffies - err_rec->last_recovery_time <= recovery_interval)) {

	if (err_rec->last_recovery_time && time_before_eq(

		jiffies - err_rec->last_recovery_time, recovery_interval)) {

		dev_err(&adapter->pdev->dev,

			"Cannot recover within %lu sec from last recovery\n",

			jiffies_to_msecs(recovery_interval) / MSEC_PER_SEC);