Commit 2f9a220e authored Sep 15, 2014 by WANG Cong Committed by David S. Miller Sep 15, 2014

net_sched: fix suspicious RCU usage in tcindex_classify()



This patch fixes the following kernel warning:

[   44.805900] [ INFO: suspicious RCU usage. ]
[   44.808946] 3.17.0-rc4+ #610 Not tainted
[   44.811831] -------------------------------
[   44.814873] net/sched/cls_tcindex.c:84 suspicious rcu_dereference_check() usage!

Fixes: commit 331b7292 ("net: sched: RCU cls_tcindex")
Cc: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: John Fastabend <john.r.fastabend@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a57a65ba

net/sched/cls_tcindex.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -81,7 +81,7 @@ tcindex_lookup(struct tcindex_data *p, u16 key)
		static int tcindex_classify(struct sk_buff skb, const struct tcf_proto tp,
		struct tcf_result *res)
		{
		struct tcindex_data *p = rcu_dereference(tp->root);
		struct tcindex_data *p = rcu_dereference_bh(tp->root);
		struct tcindex_filter_result *f;
		int key = (skb->tc_index & p->mask) >> p->shift;