Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2f7aacf7 authored by Wei Yongjun's avatar Wei Yongjun Committed by Catalin Marinas
Browse files

firmware: arm_sdei: Fix return value check in sdei_present_dt() 



In case of error, the function of_platform_device_create() returns
NULL pointer not ERR_PTR(). The IS_ERR() test in the return value
check should be replaced with NULL test.

Fixes: 677a60bd ("firmware: arm_sdei: Discover SDEI support via ACPI")
Acked-by: default avatarJames Morse <james.morse@arm.com>
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
parent a22fde8e

drivers/firmware/arm_sdei.c

+1 −1
Original line number Diff line number Diff line
@@ -1023,7 +1023,7 @@ static bool __init sdei_present_dt(void) 


	pdev = of_platform_device_create(np, sdei_driver.driver.name, NULL);

	of_node_put(np);

	if (IS_ERR(pdev))

	if (!pdev)

		return false;



	return true;