Commit 2edd69a8 authored Sep 28, 2015 by Andrzej Hajda Committed by Sebastian Reichel Sep 28, 2015

power: bq27xxx_battery: fix signedness bug in bq27xxx_battery_read_health()

We need flags to be signed for the error handling to work.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576



Fixes: 74aab849 ('power: bq27xxx_battery: Cleanup health checking')
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-By: Pali Rohár <pali.rohar@gmail.com>
Acked-by: Andrew F. Davis <afd@ti.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>

parent 2202e1fc

drivers/power/bq27xxx_battery.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -691,7 +691,7 @@ static bool bq27xxx_battery_dead(struct bq27xxx_device_info *di, u16 flags)
	*/		*/
	static int bq27xxx_battery_read_health(struct bq27xxx_device_info *di)		static int bq27xxx_battery_read_health(struct bq27xxx_device_info *di)
	{		{
	u16 flags;		int flags;

	flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, false);		flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, false);
	if (flags < 0) {		if (flags < 0) {