Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2e83b79b authored by Mateusz Guzik's avatar Mateusz Guzik Committed by Dave Chinner
Browse files

xfs: fix two memory leaks in xfs_attr_list.c error paths 



This plugs 2 trivial leaks in xfs_attr_shortform_list and
xfs_attr3_leaf_list_int.

Signed-off-by: default avatarMateusz Guzik <mguzik@redhat.com>
Cc: <stable@vger.kernel.org>
Reviewed-by: default avatarEric Sandeen <sandeen@redhat.com>
Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
parent 36f90b0a

fs/xfs/xfs_attr_list.c

+10 −9
Original line number Original line Diff line number Diff line
@@ -202,8 +202,10 @@ xfs_attr_shortform_list(xfs_attr_list_context_t *context) 
					sbp->namelen,

					sbp->namelen,

					sbp->valuelen,

					sbp->valuelen,

					&sbp->name[sbp->namelen]);

					&sbp->name[sbp->namelen]);

		if (error)

		if (error) {

			kmem_free(sbuf);

			return error;

			return error;

		}

		if (context->seen_enough)

		if (context->seen_enough)

			break;

			break;

		cursor->offset++;

		cursor->offset++;
@@ -454,8 +456,7 @@ xfs_attr3_leaf_list_int( 
				args.rmtblkcnt = xfs_attr3_rmt_blocks(

				args.rmtblkcnt = xfs_attr3_rmt_blocks(

							args.dp->i_mount, valuelen);

							args.dp->i_mount, valuelen);

				retval = xfs_attr_rmtval_get(&args);

				retval = xfs_attr_rmtval_get(&args);

				if (retval)

				if (!retval)

					return retval;

					retval = context->put_listent(context,

					retval = context->put_listent(context,

							entry->flags,

							entry->flags,

							name_rmt->name,

							name_rmt->name,