Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2e761b5a authored by Michal Kazior's avatar Michal Kazior Committed by Kalle Valo
Browse files

ath10k: remove ce_sendlist_send 



It is completely pointless to keep this function
around. It doesn't do anything different than
ce_send except it introduces more overhead.

Signed-off-by: default avatarMichal Kazior <michal.kazior@tieto.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent ddb6ad77

drivers/net/wireless/ath/ath10k/ce.c

+0 −34
Original line number Diff line number Diff line
@@ -338,40 +338,6 @@ int ath10k_ce_send(struct ath10k_ce_pipe *ce_state, 
	return ret;

}



int ath10k_ce_sendlist_send(struct ath10k_ce_pipe *ce_state,

			    void *per_transfer_context,

			    unsigned int transfer_id,

			    u32 paddr, unsigned int nbytes,

			    u32 flags)

{

	struct ath10k_ce_ring *src_ring = ce_state->src_ring;

	struct ath10k *ar = ce_state->ar;

	struct ath10k_pci *ar_pci = ath10k_pci_priv(ar);

	unsigned int nentries_mask = src_ring->nentries_mask;

	unsigned int sw_index;

	unsigned int write_index;

	int delta, ret = -ENOMEM;



	spin_lock_bh(&ar_pci->ce_lock);



	sw_index = src_ring->sw_index;

	write_index = src_ring->write_index;



	delta = CE_RING_DELTA(nentries_mask, write_index, sw_index - 1);



	if (delta >= 1) {

		ret = ath10k_ce_send_nolock(ce_state, per_transfer_context,

					    paddr, nbytes,

					    transfer_id, flags);

		if (ret)

			ath10k_warn("CE send failed: %d\n", ret);

	}



	spin_unlock_bh(&ar_pci->ce_lock);



	return ret;

}



int ath10k_ce_recv_buf_enqueue(struct ath10k_ce_pipe *ce_state,

			       void *per_recv_context,

			       u32 buffer)

drivers/net/wireless/ath/ath10k/ce.h

+0 −15
Original line number Diff line number Diff line
@@ -156,21 +156,6 @@ void ath10k_ce_send_cb_register(struct ath10k_ce_pipe *ce_state, 
				void (*send_cb)(struct ath10k_ce_pipe *),

				int disable_interrupts);



/*

 * Queue a "sendlist" of buffers to be sent using gather to a single

 * anonymous destination buffer

 *   ce         - which copy engine to use

 *   sendlist        - list of simple buffers to send using gather

 *   transfer_id     - arbitrary ID; reflected to destination

 * Returns 0 on success; otherwise an error status.

 *

 * Implemenation note: Pushes multiple buffers with Gather to Source ring.

 */

int ath10k_ce_sendlist_send(struct ath10k_ce_pipe *ce_state,

			    void *per_transfer_context,

			    unsigned int transfer_id,

			    u32 paddr, unsigned int nbytes,

			    u32 flags);



/*==================Recv=======================*/

drivers/net/wireless/ath/ath10k/pci.c

+2 −2
Original line number Diff line number Diff line
@@ -730,8 +730,8 @@ static int ath10k_pci_hif_send_head(struct ath10k *ar, u8 pipe_id, 
	pipe_info->num_sends_allowed--;

	spin_unlock_bh(&pipe_info->pipe_lock);



	ret = ath10k_ce_sendlist_send(ce_hdl, nbuf, transfer_id,

				      skb_cb->paddr, len, flags);

	ret = ath10k_ce_send(ce_hdl, nbuf, skb_cb->paddr, len, transfer_id,

			     flags);

	if (ret)

		ath10k_warn("CE send failed: %p\n", nbuf);