Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2e586a7e authored by Thomas Hellstrom's avatar Thomas Hellstrom
Browse files

drm/vmwgfx: Map the fifo as cached 



On the guest kernel side, previously the FIFO has been mapped write-
combined. This has worked since VMs up to now has not honored the mapping
type and mapped the FIFO cached anyway. Since the FIFO is accessed cached
by the CPU on the virtual device side, this leads to inconsistent
mappings once the guest starts to honor the mapping types.

So ask for cached mappings when we map the FIFO. We do this by
using ioremap_cache() instead of ioremap_wc(), and remove the MTRR setup.
On the TTM side, MOBs, GMRs and VRAM buffers are already requesting
cached mappings for kernel- and user-space.

Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: default avatarSinclair Yeh <syeh@vmware.com>
parent 54c12bc3

drivers/gpu/drm/vmwgfx/vmwgfx_drv.c

+2 −8
Original line number Diff line number Diff line
@@ -752,11 +752,7 @@ static int vmw_driver_load(struct drm_device *dev, unsigned long chipset) 
	ttm_lock_set_kill(&dev_priv->fbdev_master.lock, false, SIGTERM);

	dev_priv->active_master = &dev_priv->fbdev_master;





	dev_priv->mmio_mtrr = arch_phys_wc_add(dev_priv->mmio_start,

					       dev_priv->mmio_size);



	dev_priv->mmio_virt = ioremap_wc(dev_priv->mmio_start,

	dev_priv->mmio_virt = ioremap_cache(dev_priv->mmio_start,

					    dev_priv->mmio_size);



	if (unlikely(dev_priv->mmio_virt == NULL)) {
@@ -913,7 +909,6 @@ static int vmw_driver_load(struct drm_device *dev, unsigned long chipset) 
out_err4:

	iounmap(dev_priv->mmio_virt);

out_err3:

	arch_phys_wc_del(dev_priv->mmio_mtrr);

	vmw_ttm_global_release(dev_priv);

out_err0:

	for (i = vmw_res_context; i < vmw_res_max; ++i)
@@ -964,7 +959,6 @@ static int vmw_driver_unload(struct drm_device *dev) 


	ttm_object_device_release(&dev_priv->tdev);

	iounmap(dev_priv->mmio_virt);

	arch_phys_wc_del(dev_priv->mmio_mtrr);

	if (dev_priv->ctx.staged_bindings)

		vmw_binding_state_free(dev_priv->ctx.staged_bindings);

	vmw_ttm_global_release(dev_priv);

drivers/gpu/drm/vmwgfx/vmwgfx_drv.h

+0 −1
Original line number Diff line number Diff line
@@ -376,7 +376,6 @@ struct vmw_private { 
	uint32_t initial_width;

	uint32_t initial_height;

	u32 __iomem *mmio_virt;

	int mmio_mtrr;

	uint32_t capabilities;

	uint32_t max_gmr_ids;

	uint32_t max_gmr_pages;