Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2e4f9f20 authored by Zhipeng Lu's avatar Zhipeng Lu Committed by Greg Kroah-Hartman
Browse files

IB/hfi1: Fix a memleak in init_credit_return 



[ Upstream commit 809aa64ebff51eb170ee31a95f83b2d21efa32e2 ]

When dma_alloc_coherent fails to allocate dd->cr_base[i].va,
init_credit_return should deallocate dd->cr_base and
dd->cr_base[i] that allocated before. Or those resources
would be never freed and a memleak is triggered.

Fixes: 77241056 ("IB/hfi1: add driver files")
Signed-off-by: default avatarZhipeng Lu <alexious@zju.edu.cn>
Link: https://lore.kernel.org/r/20240112085523.3731720-1-alexious@zju.edu.cn


Acked-by: default avatarDennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 673dc4b7

drivers/infiniband/hw/hfi1/pio.c

+5 −1
Original line number Diff line number Diff line
@@ -2118,7 +2118,7 @@ int init_credit_return(struct hfi1_devdata *dd) 
				   "Unable to allocate credit return DMA range for NUMA %d\n",

				   i);

			ret = -ENOMEM;

			goto done;

			goto free_cr_base;

		}

	}

	set_dev_node(&dd->pcidev->dev, dd->node);
@@ -2126,6 +2126,10 @@ int init_credit_return(struct hfi1_devdata *dd) 
	ret = 0;

done:

	return ret;



free_cr_base:

	free_credit_return(dd);

	goto done;

}



void free_credit_return(struct hfi1_devdata *dd)