Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2d4fa7b4 authored by Daniel Lezcano's avatar Daniel Lezcano Committed by Eduardo Valentin
Browse files

thermal/drivers/hisi: Remove pointless lock 



The threaded interrupt inspect the sensors structure to look in the temp
threshold field, but this field is read-only in all the code, except in the
probe function before the threaded interrupt is set. In other words there
is not race window in the threaded interrupt when reading the field value.

Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: default avatarLeo Yan <leo.yan@linaro.org>
Signed-off-by: default avatarEduardo Valentin <edubezval@gmail.com>
parent db2b0332

drivers/thermal/hisi_thermal.c

+1 −5
Original line number Original line Diff line number Diff line
@@ -221,14 +221,10 @@ static irqreturn_t hisi_thermal_alarm_irq(int irq, void *dev) 
static irqreturn_t hisi_thermal_alarm_irq_thread(int irq, void *dev)

static irqreturn_t hisi_thermal_alarm_irq_thread(int irq, void *dev)

{

{

	struct hisi_thermal_data *data = dev;

	struct hisi_thermal_data *data = dev;

	struct hisi_thermal_sensor *sensor;

	struct hisi_thermal_sensor *sensor = &data->sensors;



	mutex_lock(&data->thermal_lock);

	sensor = &data->sensors;





	dev_crit(&data->pdev->dev, "THERMAL ALARM: T > %d\n",

	dev_crit(&data->pdev->dev, "THERMAL ALARM: T > %d\n",

		 sensor->thres_temp);

		 sensor->thres_temp);

	mutex_unlock(&data->thermal_lock);





	thermal_zone_device_update(data->sensors.tzd,

	thermal_zone_device_update(data->sensors.tzd,

				   THERMAL_EVENT_UNSPECIFIED);

				   THERMAL_EVENT_UNSPECIFIED);