Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2d329271 authored by Alan's avatar Alan Committed by Greg Kroah-Hartman
Browse files

usbip: Fix sscanf handling 



Scan only to the length permitted by the buffer

One of a set of sscanf problems noted by Jackie Chang

Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 66a01f11

drivers/staging/usbip/userspace/libsrc/usbip_common.c

+1 −1
Original line number Diff line number Diff line
@@ -165,7 +165,7 @@ int read_attr_speed(struct sysfs_device *dev) 
		goto err;

	}



	ret = sscanf(attr->value, "%s\n", speed);

	ret = sscanf(attr->value, "%99s\n", speed);

	if (ret < 1) {

		dbg("sscanf failed");

		goto err;

drivers/staging/usbip/userspace/libsrc/vhci_driver.c

+1 −1
Original line number Diff line number Diff line
@@ -72,7 +72,7 @@ static int parse_status(char *value) 
		unsigned long socket;

		char lbusid[SYSFS_BUS_ID_SIZE];



		ret = sscanf(c, "%d %d %d %x %lx %s\n",

		ret = sscanf(c, "%d %d %d %x %lx %31s\n",

				&port, &status, &speed,

				&devid, &socket, lbusid);