Commit 2d04c13a authored Sep 08, 2011 by Michael Krufky Committed by Mauro Carvalho Chehab Sep 09, 2011

[media] dvb-usb: improve sanity check of adap->active_fe in dvb_usb_ctrl_feed

The check for (adap->active_fe < 0) at the top of dvb_usb_ctrl_feed is a sanity
check to ensure that adap->active_fe is valid. Improve that sanity check
by also checking for (adap->active_fe >= adap->num_frontends_initialized)

Signed-off-by: Michael Krufky <mkrufky@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 4b5d01e9

drivers/media/dvb/dvb-usb/dvb-usb-dvb.c

+2 −1

Original line number	Original line	Diff line number	Diff line
	@@ -17,7 +17,8 @@ static int dvb_usb_ctrl_feed(struct dvb_demux_feed *dvbdmxfeed, int onoff)
	if (adap == NULL)		if (adap == NULL)
	return -ENODEV;		return -ENODEV;

	if (adap->active_fe < 0) {		if ((adap->active_fe < 0) \|\|
			(adap->active_fe >= adap->num_frontends_initialized)) {
	return -EINVAL;		return -EINVAL;
	}		}