Commit 2cf5eb3a authored Sep 15, 2015 by Johannes Berg Committed by Luca Coelho Oct 05, 2015

iwlwifi: mvm: fix D3 firmware PN programming



The code to send the RX PN data (for each TID) to the firmware
has a devastating bug: it overwrites the data for TID 0 with
all the TID data, leaving the remaining TIDs zeroed. This will
allow replays to actually be accepted by the firmware, which
could allow waking up the system.

Cc: <stable@vger.kernel.org> [3.1+]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

parent 5bd16687

drivers/net/wireless/iwlwifi/mvm/d3.c

+6 −6

Original line number	Diff line number	Diff line
		@@ -293,7 +293,7 @@ static void iwl_mvm_wowlan_program_keys(struct ieee80211_hw *hw,
		u8 *pn = seq.ccmp.pn;

		ieee80211_get_key_rx_seq(key, i, &seq);
		aes_sc->pn = cpu_to_le64((u64)pn[5] \|
		aes_sc[i].pn = cpu_to_le64((u64)pn[5] \|
		((u64)pn[4] << 8) \|
		((u64)pn[3] << 16) \|
		((u64)pn[2] << 24) \|