UPSTREAM: crypto: arm64/chacha - fix chacha_4block_xor_neon() for big endian
The change to encrypt a fifth ChaCha block using scalar instructions
caused the chacha20-neon, xchacha20-neon, and xchacha12-neon self-tests
to start failing on big endian arm64 kernels. The bug is that the
keystream block produced in 32-bit scalar registers is directly XOR'd
with the data words, which are loaded and stored in native endianness.
Thus in big endian mode the data bytes end up XOR'd with the wrong
bytes. Fix it by byte-swapping the keystream words in big endian mode.
Fixes: 2fe55987b262 ("crypto: arm64/chacha - use combined SIMD/ALU routine for more speed")
Signed-off-by:
Eric Biggers <ebiggers@google.com>
Reviewed-by:
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by:
Herbert Xu <herbert@gondor.apana.org.au>
(cherry picked from commit 4b6d196c9cec548a6b1cf5bb07b4a8b8d375829d)
Bug: 152722841
Signed-off-by:
Jason A. Donenfeld <Jason@zx2c4.com>
Change-Id: I007e5b4aa9f6dfdaea839f3fa74740321a82c682
Loading
Please register or sign in to comment