Commit 2c3dd20f authored Aug 13, 2019 by Wenwen Wang Committed by Greg Kroah-Hartman Sep 10, 2019

cxgb4: fix a memory leak bug



[ Upstream commit c554336efa9bbc28d6ec14efbee3c7d63c61a34f ]

In blocked_fl_write(), 't' is not deallocated if bitmap_parse_user() fails,
leading to a memory leak bug. To fix this issue, free t before returning
the error.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent b8cd0b7b

drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -3276,8 +3276,10 @@ static ssize_t blocked_fl_write(struct file filp, const char __user ubuf,
		return -ENOMEM;

		err = bitmap_parse_user(ubuf, count, t, adap->sge.egr_sz);
		if (err)
		if (err) {
		kvfree(t);
		return err;
		}

		bitmap_copy(adap->sge.blocked_fl, t, adap->sge.egr_sz);
		kvfree(t);