i2c: designware: report short transfers (2bf413d5) · Commits · e / devices / android_kernel_oneplus_sm7250

Rather than reporting success for a short transfer due to interrupt latency, report an error both to the caller, as well as to the kernel log. Signed-off-by:

Russell King <rmk+kernel@armlinux.org.uk> Reviewed-by:

Mika Westerberg <mika.westerberg@linux.intel.com> Acked-by:

Jarkko Nikula <jarkko.nikula@linux.intel.com> Signed-off-by:

Wolfram Sang <wsa@the-dreams.de>

drivers/i2c/busses/i2c-designware-core.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -758,7 +758,7 @@ i2c_dw_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
		}

		/* no error */
		if (likely(!dev->cmd_err)) {
		if (likely(!dev->cmd_err && !dev->status)) {
		ret = num;
		goto done;
		}
		@@ -768,6 +768,11 @@ i2c_dw_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
		ret = i2c_dw_handle_tx_abort(dev);
		goto done;
		}

		if (dev->status)
		dev_err(dev->dev,
		"transfer terminated early - interrupt latency too high?\n");

		ret = -EIO;

		done: