Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2bd6a935 authored by Arnd Hannemann's avatar Arnd Hannemann Committed by Chris Ball
Browse files

mmc: tmio_mmc: fix CMD irq handling 



With current code card insert/eject interrupts will acknowledge outstanding
commands. Normally this seems to be no problem, however if the hardware gets
stuck and no interrupts for CMD_TIMEOUT or CMD_RESPEND are generated, then
inserting and ejecting cards will falsely acknowledge outstanding commands
from the core.

This patch changes the behavior so that CMDs are only acked, if
CMD_TIMEOUT or CMD_RESPEND is received.

Signed-off-by: default avatarArnd Hannemann <arnd@arndnet.de>
Signed-off-by: default avatarChris Ball <cjb@laptop.org>
parent 6ff56e0d

drivers/mmc/host/tmio_mmc.c

+4 −2
Original line number Diff line number Diff line
@@ -727,8 +727,10 @@ static irqreturn_t tmio_mmc_irq(int irq, void *devid) 
 */



		/* Command completion */

		if (ireg & TMIO_MASK_CMD) {

			ack_mmc_irqs(host, TMIO_MASK_CMD);

		if (ireg & (TMIO_STAT_CMDRESPEND | TMIO_STAT_CMDTIMEOUT)) {

			ack_mmc_irqs(host,

				     TMIO_STAT_CMDRESPEND |

				     TMIO_STAT_CMDTIMEOUT);

			tmio_mmc_cmd_irq(host, status);

		}