Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2bafa8fa authored by Emil Tantilov's avatar Emil Tantilov Committed by Jeff Kirsher
Browse files

ixgbe: don't set RXDCTL.RLPML for 82599 



commit 2de6aa3a ("ixgbe: Add support for padding packet")

Uses RXDCTL.RLPML to limit the maximum frame size on Rx when using
build_skb. Unfortunately that register does not work on 82599.

Added an explicit check to avoid setting this register on 82599 MAC.

Extended the comment related to the setting of RXDCTL.RLPML to better
explain its purpose.

Signed-off-by: default avatarEmil Tantilov <emil.s.tantilov@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent fd492228

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

+6 −2
Original line number Diff line number Diff line
@@ -4133,11 +4133,15 @@ void ixgbe_configure_rx_ring(struct ixgbe_adapter *adapter, 
		rxdctl &= ~0x3FFFFF;

		rxdctl |=  0x080420;

#if (PAGE_SIZE < 8192)

	} else {

	/* RXDCTL.RLPML does not work on 82599 */

	} else if (hw->mac.type != ixgbe_mac_82599EB) {

		rxdctl &= ~(IXGBE_RXDCTL_RLPMLMASK |

			    IXGBE_RXDCTL_RLPML_EN);



		/* Limit the maximum frame size so we don't overrun the skb */

		/* Limit the maximum frame size so we don't overrun the skb.

		 * This can happen in SRIOV mode when the MTU of the VF is

		 * higher than the MTU of the PF.

		 */

		if (ring_uses_build_skb(ring) &&

		    !test_bit(__IXGBE_RX_3K_BUFFER, &ring->state))

			rxdctl |= IXGBE_MAX_2K_FRAME_BUILD_SKB |