Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b118859 authored by Dan Carpenter's avatar Dan Carpenter Committed by J. Bruce Fields
Browse files

nfsd: remove some dead code in nfsd_create_locked() 



We changed this around in f135af1041f ('nfsd: reorganize nfsd_create')
so "dchild" can't be an error pointer any more.  Also, dchild can't be
NULL here (and dput would already handle this even if it was).

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent fa08139d

fs/nfsd/vfs.c

+2 −3
Original line number Diff line number Diff line
@@ -1141,7 +1141,7 @@ nfsd_create_locked(struct svc_rqst *rqstp, struct svc_fh *fhp, 
		char *fname, int flen, struct iattr *iap,

		int type, dev_t rdev, struct svc_fh *resfhp)

{

	struct dentry	*dentry, *dchild = NULL;

	struct dentry	*dentry, *dchild;

	struct inode	*dirp;

	__be32		err;

	__be32		err2;
@@ -1208,7 +1208,6 @@ nfsd_create_locked(struct svc_rqst *rqstp, struct svc_fh *fhp, 
	if (!err)

		err = fh_update(resfhp);

out:

	if (dchild && !IS_ERR(dchild))

	dput(dchild);

	return err;