Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2aefee05 authored by Amitoj Kaur Chawla's avatar Amitoj Kaur Chawla Committed by Mauro Carvalho Chehab
Browse files

[media] saa7164: Replace if and BUG with BUG_ON 



Replace if condition and BUG() with a BUG_ON having the conditional
expression of the if statement as argument.

The Coccinelle semantic patch used to make this change is as follows:
@@ expression E,f; @@

(
  if (<+... f(...) ...+>) { BUG(); }
|
- if (E) { BUG(); }
+ BUG_ON(E);
)

Signed-off-by: default avatarAmitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 654043f0

drivers/media/pci/saa7164/saa7164-encoder.c

+2 −4
Original line number Original line Diff line number Diff line
@@ -1022,8 +1022,7 @@ int saa7164_encoder_register(struct saa7164_port *port) 




	dprintk(DBGLVL_ENC, "%s()\n", __func__);

	dprintk(DBGLVL_ENC, "%s()\n", __func__);





	if (port->type != SAA7164_MPEG_ENCODER)

	BUG_ON(port->type != SAA7164_MPEG_ENCODER);

		BUG();





	/* Sanity check that the PCI configuration space is active */

	/* Sanity check that the PCI configuration space is active */

	if (port->hwcfg.BARLocation == 0) {

	if (port->hwcfg.BARLocation == 0) {
@@ -1151,8 +1150,7 @@ void saa7164_encoder_unregister(struct saa7164_port *port) 




	dprintk(DBGLVL_ENC, "%s(port=%d)\n", __func__, port->nr);

	dprintk(DBGLVL_ENC, "%s(port=%d)\n", __func__, port->nr);





	if (port->type != SAA7164_MPEG_ENCODER)

	BUG_ON(port->type != SAA7164_MPEG_ENCODER);

		BUG();





	if (port->v4l_device) {

	if (port->v4l_device) {

		if (port->v4l_device->minor != -1)

		if (port->v4l_device->minor != -1)